Merged
Conversation
alan-george-lk
changed the title
stephen-derosa
approved these changes
Apr 10, 2026
Contributor
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
Looks good to me thanks for doing this!
alan-george-lk
commented
Apr 10, 2026
xianshijing-lk
approved these changes
Apr 13, 2026
Collaborator
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
one nit, lgtm if the docker builds are functional and fast.
alan-george-lk
force-pushed
the
feature/ci_unit_tests
branch
from
c7bb373 to
d6936cb
Compare
stephen-derosa
approved these changes
Apr 14, 2026
Contributor
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
lgtm -- thanks for setting this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the CI to do the following:
release-testsandrelease-examplesintegration/existed in the tests directory, but contained unit-level testing. A new folderunit/was added, which is now being executed in CINote: part of the time spent on this PR was spent investigating a separate testing stage for unit testing (and upcoming
clang-tidy), but passing artifacts between stages became pretty cumbersome and affected overall build usefulness. I think a future refactor of the CI jobs should be considered to improve this.